Fix mistakes in "Processes and Threads" #122
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dreamos82
reviewed
Jul 21, 2025
| #define KERNEL_DS 0x10 | ||
| #define USER_CS 0x18 | ||
| #define USER_DS 0x20 | ||
| ``` |
Member
There was a problem hiding this comment.
should we use them in the gdt code below? (gdt_entries[0] with i.e. gdt_entries[NULL] etc? )
Member
There was a problem hiding this comment.
gdt_entries is an array of uint64_ts, that'd break unless it was shifted. IMO it's simpler to leave the below code as is.
Contributor
Author
There was a problem hiding this comment.
yeah, that's why I mentioned (in our conversation on Discord) that the author didn't use macros as it wasn't required/relevant there.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.